BUILD_SHARED_LIBS support #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et will be static or shared depending on the BUILD_SHARED_LIBS CMake variable.
rabauke
approved these changes
Sep 5, 2021
|
On my *nix machines (openSuse 15.3 and Ubuntu 20.04) not setting the flag leads to building of just the static library. Would be nice to include in the documentation. Thank you! |
|
@MaxOremek This is the standard behavior of CMake. CMake lets you build a library either as a static or as a dynamic library. Earlier versions of TRNG implemented a hack to build build both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the feature request described in #24. There is now only a trng4 target, and the user can choose between a static and shared build by using the BUILD_SHARED_LIBS CMake variable. When an user enables BUILD_SHARED_LIBS on Windows an error message will be shown to indicate that this is currently not supported.
I have checked that tests and examples can build and launch successfully with and without BUILD_SHARED_LIBS on Linux, and without BUILD_SHARED_LIBS on Windows. Finding trng4 through find_package is also working. I could not test the change to pvs_studio_add_target as I do not have a license but hopefully it will work fine.