Constant for consumer timeout queue argument #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation to queue argument constants was missing links to the constant themselves. Go Doc allows to link to a specific symbol using squared brackets. Added as well a constant for SAC in CQ and QQ. Signed-off-by: Aitor Pérez Cedres <acedres@vmware.com>
Reported in https://github.com/rabbitmq/amqp091-go/actions/runs/5333022714/jobs/9662961511 ``` panic: runtime error: invalid memory address or nil pointer dereference panic: runtime error: invalid memory address or nil pointer dereference [signal 0xc0000005 code=0x0 addr=0x0 pc=0x7e012c] goroutine 3810 [running]: github.com/rabbitmq/amqp091-go.(*Connection).IsClosed(...) D:/a/amqp091-go/amqp091-go/connection.go:455 github.com/rabbitmq/amqp091-go.(*Connection).Close(0x0) D:/a/amqp091-go/amqp091-go/connection.go:388 +0x4c panic({0x86a960, 0xb32080}) C:/hostedtoolcache/windows/go/1.20.5/x64/src/runtime/panic.go:890 +0x263 github.com/rabbitmq/amqp091-go.(*Connection).ConnectionState(...) D:/a/amqp091-go/amqp091-go/connection.go:317 github.com/rabbitmq/amqp091-go.TestTLSHandshake.func2() D:/a/amqp091-go/amqp091-go/tls_test.go:111 +0x27b created by github.com/rabbitmq/amqp091-go.TestTLSHandshake D:/a/amqp091-go/amqp091-go/tls_test.go:104 +0x3e6 exit status 2 ``` If DialTLS returns an error, c will be nil, causing a panic later on in c.ConnectionState() Signed-off-by: Aitor Pérez Cedres <acedres@vmware.com>
Zerpet
commented
Jun 21, 2023
| @@ -66,7 +66,7 @@ func (s *tlsServer) Serve(t *testing.T) { | |||
| } | |||
|
|
|||
| func startTLSServer(t *testing.T, cfg *tls.Config) tlsServer { | |||
| l, err := tls.Listen("tcp", "127.0.0.1:0", cfg) | |||
| l, err := tls.Listen("tcp", "127.0.0.1:3456", cfg) | |||
There was a problem hiding this comment.
I'm not sure if this is necessary, but it seems to resolve flakes with tests in Windows container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation to queue argument constants was missing links to the
constant themselves. Go Doc allows to link to a specific symbol using
squared brackets.
Added as well a constant for SAC in CQ and QQ.
Fixes #201