Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example client: Rename Stream() to Consume() to avoid confusion with RabbitMQ streams #39

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

andygrunwald
Copy link
Contributor

The example client names its functionality to consume messages from a queue Stream().
With one of the latest versions of RabbitMQ, RabbitMQ Streams have been introduced.

From what I can see, the API is also using Consume, but requires custom arguments like x-queue-type. In the example client, these arguments are not used so far.

To avoid confusion between "simple" consuming and the new Streaming functionality, this PR renames Stream() to Consume().

@Zerpet
Copy link
Contributor

Zerpet commented Jan 31, 2022

Happy to merge this once the merge conflicts are resolved.

@andygrunwald
Copy link
Contributor Author

@Zerpet Fixed

@Zerpet Zerpet merged commit b52110e into rabbitmq:main Feb 4, 2022
@Zerpet
Copy link
Contributor

Zerpet commented Feb 4, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants