khepri_pattern_tree: Fix conditions that were matching subtrees #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
==========================================
- Coverage 89.75% 89.70% -0.06%
==========================================
Files 20 20
Lines 2998 3002 +4
==========================================
+ Hits 2691 2693 +2
- Misses 307 309 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
[Why] A pattern tree with `/parent/*` is supposed to match `/parent/child` but not `/parent/child/grandchild`. Before this patch, this was the case because we didn't check if we reached the of the path before calling the folding function in `khepri_pattern_tree:fold1/6`. [How] Now, we check the context and only call the fold function if we reached the end of the path. Otherwise, we recurse without calling that fold function, checking a few more things depending on whether the condition could match grand children or not. The testsuites are expanded with more testcases to cover these situations.
dumbbell
force-pushed
the
fix-pattern-tree-conditions-matching-subtrees
branch
from
93f4e41
to
f523f28
Compare
the-mikedavis
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
A pattern tree with
/parent/*is supposed to match/parent/childbut not/parent/child/grandchild.Before this patch, this was the case because we didn't check if we reached the of the path before calling the folding function in
khepri_pattern_tree:fold1/6.How
Now, we check the context and only call the fold function if we reached the end of the path.
Otherwise, we recurse without calling that fold function, checking a few more things depending on whether the condition could match grand children or not.
The testsuites are expanded with more testcases to cover these situations.