Skip to content
This repository has been archived by the owner on Nov 18, 2020. It is now read-only.

Turn auto-completion into a first class command #439

Closed
michaelklishin opened this issue Jun 30, 2020 · 0 comments · Fixed by #444
Closed

Turn auto-completion into a first class command #439

michaelklishin opened this issue Jun 30, 2020 · 0 comments · Fixed by #444
Milestone
3.8.6

Comments

@michaelklishin
Copy link
Member

michaelklishin commented Jun 30, 2020 •
edited
Loading

Autocompletion currently uses a magic argument and requires an explicit "separation" of the positional argument:

rabbitmqctl --auto-complete -- sta
# => start_app
# => status

instead, it should be a first class command that can be documented in help:

rabbitmqctl autocomplete sta
# => start_app
# => status

Per discussion with @gerhard
michaelklishin added a commit that referenced this issue Jul 2, 2020
@michaelklishin
Introduce a first class autocomplete command
b9a72d9 
Currently we have a --auto-complete magic argument which
does not show up in `help` and requires its argument to be
explcitly -- separated from the actual flag, which is
counter-intuitive.

This introduces a new autocomplete command which is delegated
to by --auto-complete, much like --help is simply a special
way of invoking the `help` command.

Closes #439
michaelklishin added a commit that referenced this issue Jul 2, 2020
@michaelklishin
More end-to-end integration tests for #439
6ba35ef
@michaelklishin michaelklishin mentioned this issue Jul 2, 2020
Merged
@michaelklishin michaelklishin added this to the 3.8.6 milestone Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.6
Development

Successfully merging a pull request may close this issue.

Introduce a first class command name autocompletion command rabbitmq/rabbitmq-cli
1 participant
@michaelklishin