Skip to content
This repository has been archived by the owner on Nov 17, 2020. It is now read-only.

Avoid multiple creation of upstream queue names on upstream exchange name (internal) compositions #80

Conversation

Ayanda-D
Copy link
Contributor

Proposed Changes

For federation exchange links, the upstream exchange name (internal) is a composition of the upstream queue name and suffix tag. The upstream queue name is initialized and created on upstream consumer initialization and held in process state. Meanwhile on initializing upstream bindings, the upstream queue name procedure is being repeatedly called/executed, when already held state, which is/can be inefficient, bearing in mind the repeated rabbit_nodes:cluster_name() calls as well. This change ensures the upstream exchange name (internal) compositions reuse composed upstream queues held in the link's state.

Types of Changes

  • Bugfix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

when defining upstream exchange name. Use that
already held in the link state.
@Ayanda-D Ayanda-D changed the title Avoid multiple creation of upstream queue names on upstream exchange names (internal) compositions Avoid multiple creation of upstream queue names on upstream exchange name (internal) compositions Jul 20, 2018
@michaelklishin michaelklishin merged commit 9aa6626 into rabbitmq:master Jul 23, 2018
@michaelklishin michaelklishin added this to the 3.7.8 milestone Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants