This repository has been archived by the owner on Nov 17, 2020. It is now read-only.
Avoid multiple creation of upstream queue names on upstream exchange name (internal) compositions #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
For federation exchange links, the upstream exchange name (internal) is a composition of the upstream queue name and suffix tag. The upstream queue name is initialized and created on upstream consumer initialization and held in process state. Meanwhile on initializing upstream bindings, the upstream queue name procedure is being repeatedly called/executed, when already held state, which is/can be inefficient, bearing in mind the repeated
rabbit_nodes:cluster_name()
calls as well. This change ensures the upstream exchange name (internal) compositions reuse composed upstream queues held in the link's state.Types of Changes
Checklist
CONTRIBUTING.md
document