Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate NullTrustManager #234

Closed
acogoluegnes opened this issue Jan 2, 2017 · 4 comments
Closed

Deprecate NullTrustManager #234

acogoluegnes opened this issue Jan 2, 2017 · 4 comments
Assignees
@acogoluegnes
Labels
enhancement usability
Milestone
4.1.0

Comments

@acogoluegnes
Copy link
Contributor

Just a matter of name, create a AlwaysTrustTrustManager clone, and remove NullTrustManager in 5.0.

See #230.
@acogoluegnes acogoluegnes added this to the 4.1.0 milestone Jan 2, 2017
@acogoluegnes acogoluegnes self-assigned this Jan 2, 2017
@michaelklishin
Copy link
Member

How about TrustEverythingTrustManager or MostNaiveTrustManager?

@acogoluegnes
Copy link
Contributor Author

I prefer my AlwaysTrustTrustManager over TrustEverythingTrustManager, but I admit the 2 Trusts in a row don't make it very readable.
I like MostNaiveTrustManager (it's so naive, it lets everyone pass), but it's not immediately obvious that it trusts everyone.
Let's go with TrustEverythingTrustManager.

@michaelklishin
Copy link
Member

OK, I'm fine with that.

acogoluegnes added a commit that referenced this issue Jan 2, 2017
@acogoluegnes
Deprecate NullTrustManager
fd672df 
Introduce TrustEverythingTrustManager.

Fixes #234
@acogoluegnes acogoluegnes mentioned this issue Jan 2, 2017
Merged
@mhewedy
Copy link

mhewedy commented May 1, 2023 •
edited
Loading

My comment has nothing to do with RabbitMQ...

I wanted to have a proper name for my "trust all TM", and I come up with NullTrustManager (in the same way as /dev/null)

But I find you changed the name, and then I liked TrustEverythingTrustManager except that it is a very long name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acogoluegnes acogoluegnes

Labels
enhancement usability
Projects
None yet
Milestone
4.1.0
Development

No branches or pull requests
3 participants
@michaelklishin @acogoluegnes @mhewedy