3.13.x only: fix timestamp when recovering x-death header #11608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug present in 3.13.3 which was introduced by #11339
When an AMQP 0.9.1 client re-publishes a message with the x-death header set, the
time
field was not converted from the AMQP 0.9.1 seconds resolution to the internal millisecond resolution ofmc
fieldsfirst_time
andlast_time
.Additionally, this commit will ignore invalid
time
fields sent in thex-death
header from AMQP 0.9.1 clients as reported in https://rabbitmq.slack.com/archives/C1EDN83PA/p1719986557420719 which results in the following crash later on when the message gets consumed: