Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off mixed version tests against Khepri #11663

Merged
merged 7 commits into from
Jul 10, 2024

Conversation

the-mikedavis
Copy link
Member

@the-mikedavis the-mikedavis commented Jul 10, 2024

Khepri v0.14.0 creates problems for mixed-version tests: the new machine version causes commands and queries to fail on the nodes running the old version. We should separately fix these issues and eventually re-enable mixed version tests with Khepri as the feature stabilizes.

Khepri is experimental and not guaranteed to be upgradable. We should
re-enable mixed version testing as Khepri stabilizes but for now we
should turn it off.

This saves some CI time and avoids some failures that will be introduced
when we upgrade Khepri to v0.14.0.
Khepri is not yet compatible with mixed-version testing and this suite
only tests clustering when Khepri is the metadata store in at least some
of the nodes.
…esia

This suite is only meant to run with Khepri as the metadata store.
Instead of setting this explicitly we can look at the configured
metadata store and conditionally skip the entire suite. This prevents
these tests from running twice in CI.
Without buildbuddy for parallelization and with the change in the parent
commit to reduce the number of cases, the suite now runs fast enough
that sharding is counterproductive.
@the-mikedavis the-mikedavis force-pushed the md/ci/turn-off-mixed-version-khepri-tests branch from 8aedc68 to 95279a3 Compare July 10, 2024 17:48
@the-mikedavis the-mikedavis marked this pull request as ready for review July 10, 2024 17:52
@the-mikedavis
Copy link
Member Author

Part of this PR is updating suites to respect the RABBITMQ_METADATA_STORE env (via rabbit_ct_broker_helpers:configured_metadata_store/1) and conditionally skip cases, groups or suites. That's necessary to avoid some failures possible when mixed version tests would fail because of Khepri even though RABBITMQ_METADATA_STORE=mnesia. This should also save us a small amount of CI time that was spent on tests run for either value of RABBITMQ_METADATA_STORE.

Before the last force-push this branch included some of the changes to bump Khepri to 0.14.0 from #11247 which has mixed-test failures in mnesia jobs. There are more places we could use rabbit_ct_broker_helpers:configured_metadata_store/1 but the changes so far were enough to have mixed versions tests pass for mnesia.

@the-mikedavis the-mikedavis merged commit ae0663d into main Jul 10, 2024
191 checks passed
@the-mikedavis the-mikedavis deleted the md/ci/turn-off-mixed-version-khepri-tests branch July 10, 2024 20:07
the-mikedavis added a commit that referenced this pull request Jul 10, 2024
Turn off mixed version tests against Khepri (backport #11663)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant