Fix /api/connections/username/{username} internal errors #8483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o internal function causing internal error
michaelklishin
changed the title
|
Apparently #5319 had no tests. I will start by adding some to Hop and |
michaelklishin
added a commit
that referenced
this pull request
Jun 6, 2023
Fix /api/connections/username/{username} internal errors (backport #8483)
michaelklishin
added a commit
to michaelklishin/rabbit-hole
that referenced
this pull request
Jun 6, 2023
michaelklishin
added a commit
to michaelklishin/rabbit-hole
that referenced
this pull request
Jun 6, 2023
and rabbitmq/rabbitmq-server#5319. Currently skipped, as they will fail on all GA releases available right now. They do pass against RabbitMQ main and 3.12, 3.11 release branches with a backport.
This was referenced Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8482, references #5319.
Calling
GET /api/connections/username/{username}as a policymaker/management user leads to a 500 internal error.Calling DETETE on
/api/connections/username/{username}as policymaker/monitor/management user leads to 500 internal error.rabbit_mgmt_wm_connection_user_name calls
rabbit_mgmt_util:is_authorized_user/3with a tuple as the 3rd argument, but it needs to be list with tuples.