Improve amqp 1.0 error handling

[kjnilsson]

Firstly avoid the explicit receive on connection to wait for link
credit. Instead we cache any early forward operations until link credit
has been received.This way any early close events are handled by the
existing callbacks.

Also wait and link the connection process until after the session
process has been started. The session process isn't started until the
sasl handshake has completed. If we link before this and sasl
authenticatio fails the shovel will not report the correct error.

Also write the report update earlier in the terminate function of the
worker.

requires: rabbitmq/rabbitmq-amqp1.0#85

[hairyhum]

I tried to test that with creating a shovel between amqp0.9.1 and amqp1.0 in rabbitmq, while not having access rights to the amqp1.0 vhost. I've got this error:

{shutdown,
    {gen_fsm,sync_send_event,
        [<0.1081.0>,
         {attach,
             #{name => <<"foo_05e2744e4b99365f_sender">>,
               rcv_settle_mode => first,
               role =>
                   {sender,
                       #{address => <<"foo1">>,durable => unsettled_state}},
               snd_settle_mode => unsettled}}]}}

Then I configured permissions for a vhost, but not the queue and I got this error:

{{badmatch,link_timeout},
 [{rabbit_amqp10_shovel,connect,7,
                        [{file,"src/rabbit_amqp10_shovel.erl"},{line,126}]},
  {rabbit_amqp10_shovel,connect_dest,1,
                        [{file,"src/rabbit_amqp10_shovel.erl"},{line,98}]},
  {rabbit_shovel_worker,handle_cast,2,
                        [{file,"src/rabbit_shovel_worker.erl"},{line,71}]},
  {gen_server2,handle_msg,2,[{file,"src/gen_server2.erl"},{line,1056}]},
  {proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,249}]}]}

Is this expected behaviour?
Is that the right way to test this issue?

[hairyhum]

I was using changes from rabbitmq/rabbitmq-amqp1.0#86 to set amqp1.0 vhost.

[kjnilsson]

You need to use the changes in rabbitmq/rabbitmq-amqp1.0#85

On Fri, 3 May 2019 at 21:55, Daniil Fedotov ***@***.***> wrote: I was using changes from rabbitmq/rabbitmq-amqp1.0#86 <rabbitmq/rabbitmq-amqp1.0#86> to set amqp1.0 vhost. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#57 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJAHFB2NV6K5WYEBCD6MKTPTSRD7ANCNFSM4HKVMDQQ> .

-- *Karl Nilsson*

[hairyhum]

@kjnilsson yes, I modified rabbitmq/rabbitmq-amqp1.0#85 with changes from rabbitmq/rabbitmq-amqp1.0#86

[michaelklishin]

I've noticed two other usability problems while QA'ing this, it's hard to evaluate Shovel AMQP 1.0 improvements in this area without addressing them. Let's merge this and work on improving the test suite and AMQP 1.0 plugin error handling in this area next.

[michaelklishin]

Backported to v3.7.x.