added queue properties parsing in SEND and SUBSCRIBE #26
Conversation
Only process the content-length header on the SEND command
... not `erlang:now()` (deprecated) or `os:timestamp()` (which could go backward). References rabbitmq/rabbitmq-server#233.
Support the new Time API in Erlang 18.0
x-dead-letter-exchange, x-dead-letter-routing-key and x-max-priority parsing in SEND and SUBSCRIBE
| {arguments, Arguments}. | ||
|
|
||
| %% build the actual value thru pattern matching | ||
| build_argument(?HEADER_X_DEAD_LETTER_EXCHANGE, Val) -> {list_to_binary(?HEADER_X_DEAD_LETTER_EXCHANGE), longstr, list_to_binary(string:strip(Val))}; |
There was a problem hiding this comment.
Please move head bodies to the next line:
build_argument(?HEADER_X_DEAD_LETTER_EXCHANGE, Val) ->
{list_to_binary(?HEADER_X_DEAD_LETTER_EXCHANGE), longstr, list_to_binary(string:strip(Val))};
|
This is submitted for |
|
There are no tests for this functionality. It should be fairly easy to test using a STOMP plugin and then |
|
I'm closing as this absolutely cannot be merged into stable. |
|
@michaelklishin should I branch from master or stable? |
|
Are there any breaking changes? If not, this can go into |
|
@michaelklishin for tests, how can I check the properties of a queue from STOMP? |
|
@priviterag simply declare the queue with the properties you expect. If they don't match what's already there, you will get a channel exception. |
|
@priviterag tests should use both STOMP and the Erlang AMQP 0-9-1 client. |
added x-message-ttl, x-expires, x-max-length, x-max-length-bytes, x-dead-letter-exchange, x-dead-letter-routing-key and x-max-priority parsing in SEND and SUBSCRIBE