This repository has been archived by the owner on Nov 18, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subs), | ||
route_state = RouteState1}) | ||
end; | ||
{error, _} = Err -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the indentation here correct?
priviterag
changed the title
Manage duplicate consumer tag error
Manage duplicate consumer tag error [DO NOT MERGE]
Sep 15, 2015
priviterag
changed the title
Manage duplicate consumer tag error [DO NOT MERGE]
Manage duplicate subscription ID error [DO NOT MERGE]
Sep 15, 2015
priviterag
changed the title
Manage duplicate subscription ID error [DO NOT MERGE]
Manage duplicate subscription ID error
Sep 15, 2015
{ok, _} -> | ||
Message = "Duplicated subscription identifier", | ||
Detail = "A subscription identified by '~s' alredy exists.", | ||
error(Message, Detail, [ConsumerTag]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this call here is producing the wrong logs:
=ERROR REPORT==== 15-Sep-2015::15:55:09 ===
STOMP error frame sent:
Message: "Duplicated subscription identifier"
Detail: "A subscription identified by '~s' alredy exists."
Server private detail: none
see error/3,4
for the proper usage
priviterag
changed the title
Manage duplicate subscription ID error
Manage duplicate subscription ID error [DO NOT MERGE]
Sep 15, 2015
priviterag
changed the title
Manage duplicate subscription ID error [DO NOT MERGE]
Manage duplicate subscription ID error
Sep 16, 2015
I've split the test into two to test different destination and headers and one of the cases fails consistently for me. |
michaelklishin
added a commit
that referenced
this pull request
Sep 16, 2015
Manage duplicate subscription ID error
This was referenced Sep 16, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
send an ERROR frame, log the error and closes the consumer connection in case of duplicate subscription ID
related to #14 & #5