Skip to content
This repository has been archived by the owner on Nov 18, 2020. It is now read-only.

Manage duplicate subscription ID error #35

Merged
merged 14 commits into from
Sep 16, 2015
Merged

Conversation

priviterag
Copy link
Contributor

send an ERROR frame, log the error and closes the consumer connection in case of duplicate subscription ID

related to #14 & #5

Subs),
route_state = RouteState1})
end;
{error, _} = Err ->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the indentation here correct?

@priviterag priviterag changed the title Manage duplicate consumer tag error Manage duplicate consumer tag error [DO NOT MERGE] Sep 15, 2015
@priviterag priviterag changed the title Manage duplicate consumer tag error [DO NOT MERGE] Manage duplicate subscription ID error [DO NOT MERGE] Sep 15, 2015
@priviterag priviterag changed the title Manage duplicate subscription ID error [DO NOT MERGE] Manage duplicate subscription ID error Sep 15, 2015
{ok, _} ->
Message = "Duplicated subscription identifier",
Detail = "A subscription identified by '~s' alredy exists.",
error(Message, Detail, [ConsumerTag]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this call here is producing the wrong logs:

=ERROR REPORT==== 15-Sep-2015::15:55:09 ===
STOMP error frame sent:
Message: "Duplicated subscription identifier"
Detail: "A subscription identified by '~s' alredy exists."
Server private detail: none

see error/3,4 for the proper usage

@priviterag priviterag changed the title Manage duplicate subscription ID error Manage duplicate subscription ID error [DO NOT MERGE] Sep 15, 2015
@priviterag priviterag changed the title Manage duplicate subscription ID error [DO NOT MERGE] Manage duplicate subscription ID error Sep 16, 2015
@michaelklishin
Copy link
Member

I've split the test into two to test different destination and headers and one of the cases fails consistently for me.

@michaelklishin michaelklishin added this to the n/a milestone Sep 16, 2015
michaelklishin added a commit that referenced this pull request Sep 16, 2015
Manage duplicate subscription ID error
@michaelklishin michaelklishin merged commit 51c9cc7 into stable Sep 16, 2015
@dumbbell dumbbell deleted the rabbitmq-stomp-14 branch January 2, 2018 16:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants