Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically download standalone language server package #103

Closed
wants to merge 17 commits into from

Conversation

tetron
Copy link
Collaborator

@tetron tetron commented Dec 18, 2020

  1. Scripted build of standalone binary packages of benten-ls using PyInstaller. (make_binary_package.py)
  2. Modify benten vscode-client to automatically download and untar the appropriate binary package for the platform & use it
  3. Now expects that vscode client and benten-ls versions are synchronized (this means if you update the vscode plugin it'll automatically get the language server package corresponding to the update).

To do:

  • See about building binary package on MacOS
  • Decide where to host the binary packages
  • Ideally, set up a multi-platform CI system like AppVeyor to build PyInstaller packages for each platform automatically (PyInstaller does not cross compile). However we can do an initial release with manually-built packages.

@codecov-io
Copy link

codecov-io commented Dec 18, 2020

Codecov Report

Merging #103 (9583ba5) into master (3630ec9) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage   70.33%   70.30%   -0.03%     
==========================================
  Files          40       40              
  Lines        2043     2041       -2     
==========================================
- Hits         1437     1435       -2     
  Misses        606      606              
Impacted Files Coverage Δ
benten/configuration.py 87.23% <100.00%> (-0.27%) ⬇️
benten/cwl/specification.py 97.56% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3630ec9...9583ba5. Read the comment docs.

@tetron tetron marked this pull request as draft December 18, 2020 20:40
Don't block adding the visualization panel on tool download.
Schemas are now considered package data, which is more portable.  They
are now in a separate benten_schemas module to avoid search path
conflicts with the main benten module.
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz@curii.com>
@ghost ghost self-requested a review December 22, 2020 15:34
@tetron
Copy link
Collaborator Author

tetron commented Jan 4, 2021

This is superceded by the kg/dist-install branch

@tetron tetron closed this Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants