This repository has been archived by the owner on Apr 21, 2019. It is now read-only.
Style guide #70
Merged
Style guide #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 2. Avoid passing function references as arguments. | ||
| 3. Only surround arrow function parameters when | ||
| For example, `(x) => x + x` is wrong but the following are correct: | ||
| - `x => x + x` |
There was a problem hiding this comment.
What if you want to give the parameter a type? x: number => x+ x will not work, you need to say (x: number) => x + x
There was a problem hiding this comment.
Yes, read the lines below :)
The point is to use the simplest expression needed.
If there's a single argument for which the type is inferred, no need for parentheses, an so on.
There was a problem hiding this comment.
Incomplete sentence: Only surround arrow function parameters when... when what? :)
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the first style guide doc draft.
This change is