Fallback + Python<3.7 install for importlib_resources #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @illusional thanks for the PR. Will this allow installation on Py 2.x? The code will not work on Py 2.x and I don't really want to support Py 2.x . |
|
I mean, by itself it won’t. It just came with the block of code I referred to for fallback. I can change the comment to better describe the sitch, maybe like “for python <3.7 without importlib.resources by default’. I can also change the python requires tag in setup.py if you want that as part of this PR. |
ghost
reviewed
May 8, 2020
|
Hi @illusional anything that ensures pip does not try to install for earlier than 3.6 is fine. The code uses string literals, which were introduced in 3.6 |
|
Hey @kaushik-work, I added a commit to address your review. |
ghost
merged commit
|
Thanks so much @illusional ! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses conversation and closes #5.