Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create knn_params class #3

Closed
4 tasks done
rabutler-usbr opened this issue Nov 30, 2018 · 0 comments
Closed
4 tasks done

create knn_params class #3

rabutler-usbr opened this issue Nov 30, 2018 · 0 comments
Labels
done

Comments

@rabutler-usbr
Copy link
Owner

rabutler-usbr commented Nov 30, 2018 •
edited
Loading

in knn_get_index_year(), the k_weights argument needs to be a list with a lot of special characteristics

So, make it require a k_params class. This should simplify a lot of the checks we have built in.

  • create a default k_params class that can be used as the default to knn_get_index_year()
  • ensure all code is covered by tests
  • enhance examples in knn_params() and knn_params_default()
  • verify class is properly documented
@rabutler-usbr rabutler-usbr changed the title create k_params class create knn_params class Nov 30, 2018
rabutler-usbr added a commit that referenced this issue Nov 30, 2018
@rabutler-usbr
created knn_params class
0d288f6 
working on #3

- created class
- created default function that uses Nowak et al.'s parameters
- edited `knn_get_index_year()` and `knn_space_time_disagg()` to use the default functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rabutler-usbr