-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add uint64 support for the session id #29
Add uint64 support for the session id #29
Conversation
Hi @DerkJanSpeelman thank you for your PR. This looks good! Can you please check out the tests (update them if necessary) so I can merge your changes? Thank you |
I'd love to, but the Travis CI is setup with Node v10.19.0. Therefore:
|
@DerkJanSpeelman merged 👍 |
@DerkJanSpeelman I had to revert this PR due because Travis running node 8, 10 wasn't the (only) problem: the tests are failing to check the value of |
Add uint64 support for the missing session id
I wanted to fetch the
m_sessionUID
inside thePacketHeader
(sent inside every message). I found out there wasn'tuint64
support withTypeScript 3.1.0
and the includedbinary-parser
(version 1.3.2). So, I upgraded these packages. And everything seems to be working fine.I'm also running on a newer version of Node (Latest Current Version 13.8.0). Thereby, it added a few version changes to the
package-lock.json
. But it should run fine from version 12 onwards:The methods readBigInt64BE, readBigInt64BE, readBigInt64BE, readBigInt64BE are not avilable in your version of nodejs: v10.19.0, you must use v12 or greater
I added
m_sessionUID
to thePacketHeader
In
src\parsers\packets\PacketHeaderParser.ts:18
, I added the sessionUID. We might want to change thisuint64
to auint64le
class
is extending anamespace
I also found a bug the
F1TelemetryClient
class. This class extends theEventEmitter
namespace, not the class. Just a small fix.PacketSessionData
I added the
m_formula
in thePacketSessionData
interface. ThePacketSessionData
with thePacketHeader
included now looks like this:Note: check the
m_sessionUID
andformula
attributes. Andm_pitSpeedLimit
is just the end of the screenshot, the regular data is still there ofcourse.