Make the CI fail when testing on JRuby fails #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
drop-experimental-flag-from-jruby
branch
from
5eda9e3
to
0f8cca3
Compare
|
What is your goal with this PR? |
Treat JRuby as a first-class citizen. Now, in my opinion, JRuby has enough traction to warrant treating it like any other CRuby version. This is just an opinion. In the absence of a formal compatibility list, this change doesn't imply that JRuby is supported. |
ioquatix
approved these changes
Jan 19, 2024
ioquatix
force-pushed
the
drop-experimental-flag-from-jruby
branch
from
0f8cca3
to
ddb43cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal in the form of a PR.
EDIT:
#32 must be merged first.