Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save session during follow_redirect! #218

Merged
merged 3 commits into from
Mar 8, 2018

Conversation

AlexWayfer
Copy link
Contributor

It's helpful (and necessary) for tests of actions with session modifications and redirects
(redirects + flashes, for example).

AlexWayfer and others added 3 commits March 5, 2018 18:42
It's helpful (and necessary) for tests of actions with session modifications and redirects
(redirects + flashes, for example).
Copy link
Contributor

@perlun perlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 Will merge once the CI runs are ready.

@AlexWayfer
Copy link
Contributor Author

Thank you! Sorry for missed attribution.

@perlun
Copy link
Contributor

perlun commented Mar 8, 2018

Sorry for missed attribution.

No probs at all. Looks good now, merging. Thanks for your contribution! 👍

@perlun perlun merged commit 095f0ae into rack:master Mar 8, 2018
AlexWayfer added a commit to AlexWayfer/flame-flash that referenced this pull request Mar 27, 2018
@AlexWayfer AlexWayfer deleted the save_session_on_follow_redirect branch July 18, 2018 17:01
alex-damian-negru pushed a commit to alex-damian-negru/rack-test that referenced this pull request Apr 5, 2021
* Save `session` during `follow_redirect!`

It's helpful (and necessary) for tests of actions with session modifications and redirects
(redirects + flashes, for example).

* Added attribution in History.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants