-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow original_filename to be used for all content types #314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, please see requested changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just a minor suggested change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
Any ideas when you might be able to push a release out with this change in? Only so I can get rid of some hacky code I threw in a project to workaround 😄 |
We are probably at least a few weeks out from a release, considering 2.0.0 was released less than 2 weeks ago. |
Last release has few months ago. Any plan to release this change ? |
@jeremyevans is there any reason why we can't release 2.1? or something else? |
I can put out a new release this week. |
Allow
original_filename
to be used for all content types not justStringIO
, so that the generated Tempfile can potentially renamed when generated.