Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a small working example #65

Closed
wants to merge 1 commit into from
Closed

Conversation

mulderp
Copy link

@mulderp mulderp commented Sep 27, 2012

Hi,

just as an idea to use a working example in the README

It's maybe easier to see that such things as headers, etc. can be tested.

Well... this commit is not rocket science, but maybe would be interesting for some or the other. Actually in combination with Capybara this might open up new ways for testing.

Patrick

@brynary
Copy link
Collaborator

brynary commented Nov 11, 2012

Thanks, Patrick. Why do you prefer this example to the previous one?

@mulderp
Copy link
Author

mulderp commented Nov 11, 2012

Yes, I was just starting on learning about Rack in general. From my understanding, there are 3 types of rack app's used:

  • lambda function with one static response
  • Sinatra apps
  • Rails apps

When learning on Rack, the lambda function seems to be the standard use case, which I was thinking that showing this in an example might be nice.
After some weeks, I see that the config.ru parsing also provides enough hints, on how to test apps with Rack test.
Not sure, if my explanation makes sense. Thanks for you feedback/interest in any case.

@junaruga
Copy link
Contributor

As a reference, there is another PR to add require "test/unit".
#74

@dennissivia
Copy link

@junaruga I would actually like the improved example as well.
@mulderp are you still available and could you rebase your PR on the latest master to fix the merge issue?

@junaruga
Copy link
Contributor

junaruga commented May 15, 2017

@scepticulous I would prefer the improved example as well. I agree with you. If some people like other use cases (types)' examples in the future, I want to split the example section from README, and link from the README to sample/*.rb.

@mulderp
Copy link
Author

mulderp commented May 15, 2017

@scepticulous thanks for the ping - unfortunately, I am not working with Ruby anymore for some years.
I think it makes sense that I close the PR and you can go ahead and open an updated one.

@mulderp mulderp closed this May 15, 2017
dennissivia added a commit that referenced this pull request May 15, 2017
This PR implements PRs #65, #74 and #78.
Some of the PRs contain similar content and other are no longer
based on the current readme. THis is an attempt to clean up the
readme state. In addition some suggestions for further updates
are part of the PR to raise the discussion about:
List of maintainers and the format (email or github username) and
the copyright text we want to have (or not have).
@dennissivia
Copy link

Implemented in #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants