Don't recommend installing gem with sudo #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Bump.) |
|
👍 |
junaruga
approved these changes
Apr 26, 2017
junaruga
added a commit
to junaruga/rack-test
that referenced
this pull request
Apr 26, 2017
Closed
|
@junaruga I've rebased this PR so it can be merged straight from GitHub's UI. |
|
@tjschuck thanks! merged! |
|
@junaruga Thanks for the blast from the past :) |
alex-damian-negru
pushed a commit
to alex-damian-negru/rack-test
that referenced
this pull request
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since gems can execute arbitrary code, installing with sudo can get dangerous if anyone manages to hijack this gem or one if it's dependencies on RubyGems.
If a user wants to install with sudo, they certainly can, and then they are assuming all the risk by being explicit. But it should not be recommended.
See also: http://masanjin.net/blog/sudo-gem-install-considered-harmful