Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Give parse_query's second argument a default value
- Loading branch information
d68b93a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spastorino note this doesn't help compatibility with older Rails -- we're not calling the method: we're overriding it
d68b93a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthewd yep, anyway both changes are better. Having a default here and using (*) in Rails
d68b93a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks capybara for me with rspec and Rails 4.2.1 and 4.2.2.
d68b93a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hermanverschooten it's probably not this commit, can you give us more information?.
d68b93a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, indeed it wasn't this commit. see issue #896, it is the commit that adds the second parameter to parse_query.
d68b93a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was this commit actually. See PR #781. I have 2 PRs open now that resolves this and the tests still pass.