Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating Color Scheme: what are these modifiable settings? #432

Open
Draculah opened this issue Oct 29, 2020 · 9 comments
Open

Creating Color Scheme: what are these modifiable settings? #432

Draculah opened this issue Oct 29, 2020 · 9 comments

Comments

@Draculah
Copy link

I have created a simple dracula color scheme package, which is semi complete; I only can't find what these settings are:

(drracket:syncheck:untacked                ,unknown)
(framework:disabled-background-color       ,unknown)

(stepper:arrow-color             ,unknown)
(stepper:error-color             ,unknown)
(stepper:redex-highlight-color   ,unknown)
(stepper:reduct-highlight-color  ,unknown)

(framework:line-numbers-current-line-number-background  ,unknown)
(framework:line-numbers-current-line-number-foreground  ,unknown)

I was wondering whether there is some documentation that describes these settings, and if it's possible that these changes are simply not visible on windows, while they are at other OS?

I tried giving them a color (unknown) that was very easy to find, but wasn't able to see it's usage. Not a big deal if it's not included, but if it's possible, I would like to add extra line-number settings, but I'm not able to.

I honestly don't know how to add tags, but this should be a question, I suppose.

@rfindler
Copy link
Member

rfindler commented Oct 29, 2020 via email

@Draculah
Copy link
Author

Draculah commented Oct 29, 2020

Thank you for the quick reply; I think I shall try the remaining settings with what you gave me. There is only the line-numbers: I already have them shown, of course :-)

DrRacket

If I understand correctly, the framework:line-numbers-current-line-number-background and framework:line-numbers-current-line-number-foreground should overwrite the blue and white colors of the indicator at the left with unknown , which doesn't seem to be the case. Is it a bug then?

To give extra details:

  • I have reloaded my DrRacket, just like for all colour settings, and
  • I'm on Windows 10.

P.S.: how do I add the question tag to this question? or is that a specific task for a community member?

@rfindler
Copy link
Member

I don't know about the question tag! Maybe @samth does.

Looking at the source code and the docs it seems like that blue color takes priority because it is the selection color. If you change that (via the OS) do you see changes? That shade of blue looks familiar as the default text selection color on windows.

@Draculah
Copy link
Author

:o Hm, I thought I could help out so you guys didn't have to label them anymore. Guess I shall not mention question anymore :))

I changed the selection color to green as described here, and indeed, the indicator for the insertion line became green as well.

DrRacket with a green indicator

Does this mean I can't modify those two framework:line-numbers settings, or it just doesn't work on Windows? Thanks in advance.

@rfindler
Copy link
Member

I suppose it could make sense to make a pull request to change the way things work. If we did that, probably we'd have to be careful to preserve backwards compatibility.

@Draculah
Copy link
Author

I suppose it could make sense to make a pull request to change the way things work. If we did that, probably we'd have to be careful to preserve backwards compatibility.

I'd love to help out, but I'm only a student with very basic scheme experience (R5RS) and almost zero using github, so for now it's better for the sake of DrRacket to not let me touch them. But if I would find time to do so, I might rewrite it so that windows has a dark gui as well :D

Thanks for investigating it anyway!

@rfindler
Copy link
Member

Yeah, the lack of a dark mode in windows is annoying! The problem seems to be that the OS is not cooperating (i.e., everything except what windows itself draws can be made into dark mode, but the OS is drawing things like menus and buttons)

@samth
Copy link
Member

samth commented Oct 30, 2020

Unfortunately you can't change tags unless you can commit to the repo.

@Draculah
Copy link
Author

@samth ah, right. Should I close this issue now, or wait for someone to find out what's the default-background-color? I'm kinda new to posting issues, as you must have noticed. So I don't know whether it's bothering or not, having opened issues.

@rfindler so it is something that should be changed to the racket/gui?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants