Fix race condition when watcher is killed too fast #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a client disconnects normally very quickly, the watcher is killed before its channel is read, causing connection to block indefinitely. To fix, try reading from the watcher's channel after killing it, to unblock the connection's main thread.
mflatt
reviewed
Jul 14, 2022
If a client disconnected normally very quickly, the watcher is killed before its channel is read, causing the connection to block indefinitely. To fix, give up on the put if the watcher thread is dead.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a client disconnects normally very quickly, the watcher is killed
before its channel is read, causing connection to block indefinitely.
To fix, try reading from the watcher's channel after killing it, tounblock the connection's main thread.
To fix, give up on the put if the watcher is dead.
Fixes #55