-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved cheeck-= and check-within error messages #166
Conversation
Added tolerance information
Added tolerance information
You said that the PR is intended to "Improved documentation", but I don't see the documentation change anywhere. Did you forget to commit some changes? It would be nice to write tests to make sure that the message contains the added information. Probably here. If you don't want to do that, I can merge the PR now and work on the test as a separate change, too. But this overall looks good. Thanks! |
Improved documentation and error messages of |
Added Avogadro constant and Gravity constant functions.
(check-within (list 6 10) (list 6.02 9.99) 0.05) | ||
(check-within (flvector 3.0 4.0 5.0) (flvector 3.01 4.01 5.014) 0.02) | ||
(check-within (hash 'C 20 'F 68) (hash 'C 25 'F 77) 10) | ||
(check-within (list 6.02 9.99) (list 6 10) 0.05) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the tests are ok.
There are more changes I'd like to make, but they are just nits, so I'll go ahead and merge this, and make the change later. In particular, I'd like to keep similarity between "For example, the following checks pass:" and "And the following checks fail:" as much as possible, so that readers can contrast them easily. That means:
|
Thank you very much sorawee!
Matteo d’Addio
…________________________________
Da: sorawee ***@***.***>
Inviato: Saturday, November 4, 2023 3:23:04 PM
A: racket/rackunit ***@***.***>
Cc: matteo-daddio ***@***.***>; Author ***@***.***>
Oggetto: Re: [racket/rackunit] Improved cheeck-= and check-within error messages (PR #166)
Merged #166<#166> into master.
—
Reply to this email directly, view it on GitHub<#166 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZ2CGPIQIJSHOGYI6EPLS2TYCZFURAVCNFSM6AAAAAA62WUQ2CVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQHA3DEOJSGEZDGOI>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Improved documentation and error messages of
check-=
andcheck-within
as discussed in issue #165.