Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-derivations doesn't save names at leaves #16

Closed
wilbowma opened this issue Oct 3, 2015 · 2 comments
Closed

build-derivations doesn't save names at leaves #16

wilbowma opened this issue Oct 3, 2015 · 2 comments

Comments

@wilbowma
Copy link
Collaborator

wilbowma commented Oct 3, 2015

The leaves in a derivation returned by build-derivations don't seem to have names, even when the rules used have names in the judgment-form.

For example, see the example given in the documentation:

> (build-derivations (even (s (s z))))
(list
 (derivation '(even (s (s z))) "even2" (list (derivation '(even z) "" '()))))

The leaf of the derivation uses "evenz", but the name given is "".
@wilbowma wilbowma changed the title build-derivations doesn build-derivations doesn't save names at leaves Oct 3, 2015
@rfindler
Copy link
Member

rfindler commented Oct 3, 2015

It actually does -- this was a bug in the caching logic (trying to share cache results from build-derivations and judgment-holds in a bad way)

rfindler added a commit that referenced this issue Oct 3, 2015
@rfindler
completely segregate the judgment-holds cache from the build-derivati…
45f342f 
…ons cache

closes github pr #16
@wilbowma
Copy link
Collaborator Author

wilbowma commented Oct 3, 2015

This fixes my problems; thanks!

@wilbowma wilbowma closed this as completed Oct 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rfindler @wilbowma