Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case sensitivity issues in bibtex #264

Closed
wants to merge 4 commits into from

Conversation

wilbowma
Copy link
Contributor

bibtex is supposed to treat keys and labels as case insensitive, according to what I can find (http://maverick.inria.fr/~Xavier.Decoret/resources/xdkbibtex/bibtex_summary.html#stringdef). This was mostly true already, but labels and entry keys were not treated this way. This patch fixes it.

@wilbowma
Copy link
Contributor Author

Closes #261

@mflatt
Copy link
Member

mflatt commented Aug 19, 2020

I'm happy to merge this, but checking on one detail first: Using string-foldcase is normally more correct than string-downcase for setting up a case-insensitive comparison. It doesn't matter for English/Latin/ASCII letters, and really you want to do the same as bibtex, which may well be downcase. Do you want to keep downcase or change to foldcase?

@wilbowma
Copy link
Contributor Author

Should probably use string-foldcase. I was following the existing patterns in the file, which uses string-downcase; I didn't realize I ought to use string-foldcase. However, this means the other uses should probably be changed.

@mflatt
Copy link
Member

mflatt commented Aug 23, 2020

Merged (but out of GitHub to deal with conflicts).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants