Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom cw agent configuration parmater store input #38

Merged
merged 2 commits into from
Jan 15, 2019

Conversation

mjcmtb
Copy link
Contributor

@mjcmtb mjcmtb commented Jan 14, 2019

Corresponding Issue(s) or trello card(s):

https://github.com/rackspace-infrastructure-automation/aws-terraform-internal/issues/162

Summary of change(s):

Add variables to optionally provide an alternate parameter store item that stores that CloudWatch agent configuration.

Will the change trigger resource destruction or replacement? If yes, please provide justification:

No

Does this update/change involve issues with other external modules? If so, please describe the scenario.

This same change will be made to the ec2_asg module.

If input variables or output variables have changed or has been added, have you updated the README?

Yes

Do examples need to be updated based on changes?

Yes - Updated.

Note to the PR requester about Closing PR's

Please message the person that opened the issue when auto closing it on slack, as well as any other stake holders of deep interest. Only close the issue if you believe that the issue is fully resolved with this PR.

This PR may auto close the issue associated with it. If you feel the issue is not resolved please reopen the issue.

Copy link
Contributor

@johnctitus johnctitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, although I would also recommend we add a count to the "aws_ssm_parameter" "cwagentparam" resource, and don't create it if we were passed a custom cw agent config.

Copy link
Contributor

@johnctitus johnctitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after changes

Copy link
Contributor

@bohn002 bohn002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjcmtb mjcmtb merged commit 4683211 into master Jan 15, 2019
@gdelvalle gdelvalle deleted the mc_custom_cw_config branch January 15, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants