This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
[rfr] Extract additional info from GET #564
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to extract project information out of a scoped v3 token.
Return a list of the roles associated with a scoped token.
The service catalog object can be retrieved from a GET request when doing token validation as well as the POST request.
Get user information out of token information from a GET response
|
When this is ready for review, throw a |
kaccardi
changed the title
|
ok, I modified the title, thanks. |
|
|
||
| // Roles contains a list of role names extracted from a token. | ||
| type Roles struct { | ||
| Entries []RoleEntry |
|
These look good. Can you add unit tests for them? |
|
yes, I will work on that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some additional APIs to extract project, roles, and user information from a token retrieved with a GET request. Move ExtractServiceCatalog to commonResult since it can be obtained either with a POST or a GET.