Add ability to interact with backups. #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still could probably use some more tests |
|
Related: #337 |
| public $datastore; | ||
| public $updated; | ||
| public $instance; | ||
| public $instance_id; |
There was a problem hiding this comment.
This needs to be camel case (instanceId). You can then alias instance_id like so.
|
@evanlucas 👍 This is really good, thank you so much for submitting! I've annotated a lot of stuff with some thoughts - if anything's unclear feel to comment on it and I'll elaborate on what I mean |
evanlucas
force-pushed
the
backups
branch
2 times, most recently
from
4adc887
to
90f4561
Compare
|
Strange, apparently, the API does not accept the description if it is |
|
Ok, just added a fix to account for the description issue. All other comments should be addressed. :] |
1 similar comment
jamiehannaford
pushed a commit
that referenced
this pull request
May 27, 2015
Add ability to interact with backups.
|
@evanlucas This is perfect, thanks for all your hard work! 🚀 |
|
Glad to help out :] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.