Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pydantic data model to parse cfngin.hooks.docker hook arguments #1219

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

ITProKyle
Copy link
Collaborator

Summary

Replace pydantic stand-in with pydantic models for parsing hook arguments.

Why This Is Needed

resolves #1164

What Changed

Changed

  • data models used to parse runway.cfngin.hooks.docker hook arguments are now pydantic data models

@ITProKyle ITProKyle added the changelog:minor Minor change resulting in a minor release label Jan 26, 2022
@ITProKyle ITProKyle self-assigned this Jan 26, 2022
@github-actions github-actions bot added feature Request or pull request for a new feature python Update to Python code labels Jan 26, 2022
@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #1219 (8cfbfac) into master (62cf452) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1219      +/-   ##
==========================================
- Coverage   89.52%   89.45%   -0.07%     
==========================================
  Files         247      247              
  Lines       15312    15218      -94     
==========================================
- Hits        13708    13614      -94     
  Misses       1604     1604              
Impacted Files Coverage Δ
runway/cfngin/hooks/docker/_login.py 100.00% <100.00%> (ø)
runway/cfngin/hooks/docker/data_models.py 100.00% <100.00%> (ø)
runway/cfngin/hooks/docker/image/_build.py 100.00% <100.00%> (ø)
runway/cfngin/hooks/docker/image/_push.py 100.00% <100.00%> (ø)
runway/cfngin/hooks/docker/image/_remove.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62cf452...8cfbfac. Read the comment docs.

@ITProKyle ITProKyle merged commit 8d31779 into master Jan 26, 2022
@ITProKyle ITProKyle deleted the feature/docker-hook-args branch January 26, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:minor Minor change resulting in a minor release feature Request or pull request for a new feature python Update to Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use pydantic to parse arguments for all runway.cfngin.hooks.docker hooks
1 participant