Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tf workspace key prefix support #1757

Merged
merged 9 commits into from
Jan 23, 2023

Conversation

mbordash2
Copy link
Contributor

@mbordash2 mbordash2 commented Jan 10, 2023

Adding support for Terraform state workspace_key_prefix option.

Summary

Updated Terraform backend config data model to support workspace_key_prefix.

Why This Is Needed

closes #1595

What Changed

Added

Support for new Terraform backend config option.

Checklist

  • Have you followed the guidelines in our Contribution Requirements?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?
  • Have you linted your code locally prior to submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Have you updated documentation, as applicable?

@github-actions github-actions bot added feature Request or pull request for a new feature python Update to Python code labels Jan 10, 2023
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #1757 (0948a72) into master (915f30e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1757   +/-   ##
=======================================
  Coverage   90.17%   90.17%           
=======================================
  Files         247      247           
  Lines       15424    15425    +1     
=======================================
+ Hits        13909    13910    +1     
  Misses       1515     1515           
Impacted Files Coverage Δ
runway/module/utils.py 100.00% <ø> (ø)
runway/config/models/runway/options/terraform.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 915f30e...0948a72. Read the comment docs.

@mbordash2
Copy link
Contributor Author

All CI/CD tests are now passing.

@mbordash2 mbordash2 merged commit 3696cec into master Jan 23, 2023
@mbordash2 mbordash2 deleted the feature/tf-workspace-key-prefix-support branch January 23, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Request or pull request for a new feature python Update to Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] terraform_backend_config -> workspace_key_prefix not supported in 2.6.3
2 participants