Advise not to track track Gemfile.lock for gem development #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Further explanation from Bundler's author: http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/ Fixes radar#14 Closes radar#23
|
Of course this patch doesn't bring the entire guide up to date, but I think that's a separate endeavor that will require some more dedicated time. Some things I happened to notice while working:
|
|
Thanks @nilbus! I can probably look at fixing up the other things. |
gregburek
added a commit
to gregburek/sequel-caller-location
that referenced
this pull request
Sep 27, 2017
http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/ > In general, a gem's Gemfile should contain the Rubygems source and > a single gemspec line. Do not check your Gemfile.lock into version > control, since it enforces precision that does not exist in the gem > command, which is used to install gems in practice. Even if the > precision could be enforced, you wouldn't want it, since it would > prevent people from using your library with versions of its dependencies > that are different from the ones you used to develop the gem. radar/guides#74
cyberdelia
pushed a commit
to cyberdelia/sequel-caller-location
that referenced
this pull request
Oct 2, 2017
http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/ > In general, a gem's Gemfile should contain the Rubygems source and > a single gemspec line. Do not check your Gemfile.lock into version > control, since it enforces precision that does not exist in the gem > command, which is used to install gems in practice. Even if the > precision could be enforced, you wouldn't want it, since it would > prevent people from using your library with versions of its dependencies > that are different from the ones you used to develop the gem. radar/guides#74
|
FYI, this is no longer the official advice... see https://github.com/bundler/bundler/issues/5879 & friends. |
|
Thanks @matthewd. Probably high time I removed this guide from this repo, as the Bundler guide is a more up-to-date copy of that same guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further explanation from Bundler's author, Yehuda Katz:
http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/
Fixes #14
Closes #23, now obsolete