Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missed and remove doubled numbers #54

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Add missed and remove doubled numbers #54

merged 1 commit into from
Jun 28, 2019

Conversation

dmitrykleymenov
Copy link
Contributor

There were missed and extra values in Russian SUB_ONE_GROUPING constant. Added a couple of tests.

@dmitrykleymenov dmitrykleymenov mentioned this pull request Jun 28, 2019
Closed
@styd styd assigned styd and unassigned styd Jun 28, 2019
@styd
Copy link
Collaborator

styd commented Jun 28, 2019

@arharovets, can you review this PR?

@arharovets
Copy link
Contributor

Hi @styd,

Sure, give me an evening, okay?

arharovets
arharovets approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@arharovets arharovets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DukeFruitarian,

You have a very sharp eye! Thank you!

@dmitrykleymenov
Copy link
Contributor Author

@arharovets Thanks

@styd styd merged commit bb237f8 into radar:master Jun 28, 2019
@styd
Copy link
Collaborator

styd commented Jun 28, 2019

@DukeFruitarian, @arharovets, thank you, guys.

@dmitrykleymenov dmitrykleymenov deleted the bug/russian_incorrect_numbers branch June 28, 2019 15:29
@dmitrykleymenov dmitrykleymenov restored the bug/russian_incorrect_numbers branch June 28, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arharovets arharovets arharovets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmitrykleymenov @styd @arharovets