noreturn functions not working on windows binaries

[radare]

[0x00401cda]> tn
ExitProcess

• those are all the no-return functions for windows
• i guess this list should be longer :P
• and this ExitProcess should be catching this call sub.kernel32.ExitProcess....

[radare]

cc @xarkes

[Maijin]

Since the information is stored in sdb and no sdb is read it can't work -> https://github.com/radare/radare2/issues/7829

[radare]

the bug happens on linux too by just opening a windows binary, and there's a broken test already. so its completely unrelated to the sdb problem.

[radare]

And the reason why sdb doesnt works on windows is because sdb databases cant be generated with meson. Not because any weird bug ir so Another solution wiuld be to just do a bat script to build them all in the release script. Sdb files arent required at compile time. Just at runtime and on windows we can load them from a relative path from the executables instead of a full path.

…

On 21 Jul 2017, at 19:41, Maijin ***@***.***> wrote: Since the information is stored in sdb and no sdb is read it can't work -> #7829 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[Maijin]

Ah it's because it's probably an exact match instead of a contains

[radare]

Yep. Also the way imports are named in PE. That sub thing shouldnt happen imho, but as long as on windows uncan have more than one import pointing to the same ordinal we cant do fixed matching

…

On 21 Jul 2017, at 21:33, Maijin ***@***.***> wrote: Ah it's because it's probably an exact match instead of a contains — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[radare]

this should be easy to fix , anyone?

[radare]

moving for 2.2 until we have a test case for this. anyone?

[radare]

PING?

[kriw]

Could I work on this issue though someone is assigned,

[Maijin]

Yes no worries @kriw

[sivaramaaa]

@kriw Yup it's ok u could work on it , i could wait for ur implementation , but this has to be done before the release
meanwhile i will be working on this issue : r2 /bin/ls - wrong main detection @radare

[radare]

Ok!

…

On 20 Dec 2017, at 02:18, sivaramaaa ***@***.***> wrote: @kriw Yup it's ok u could work on it , i could wait for ur implementation , but this has to be done before the release meanwhile i will be working on this issue : r2 /bin/ls - wrong main detection @radare — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.