Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8198, Avoid restoring and replaying session twice in dsb command #9794

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Fix #8198, Avoid restoring and replaying session twice in dsb command #9794

merged 1 commit into from
Apr 4, 2018

Conversation

sivaramaaa
Copy link
Contributor

Before the patch

  1. dsb command was restoring the session and replaying it once to just get the previous instr addr
  2. then it again restores session and replay it until prev instr

After the patch

  1. now we restore and replay only once and calculate previous instr addr using opcode length

@radare
Copy link
Collaborator

radare commented Apr 4, 2018

looks green for travis

@radare radare merged commit 17061a7 into radareorg:master Apr 4, 2018
@sivaramaaa sivaramaaa deleted the fix-8198 branch April 8, 2018 16:59
SakiiR pushed a commit to SakiiR/radare2 that referenced this pull request Jul 1, 2019
@sivaramaaa @radare
Fix radareorg#8198, Avoid restoring and replaying session twice in ev…
f81f806 
…ery step back command (radareorg#9794)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sivaramaaa @radare