Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting this pull request to make liblo compatible with the libmapper Arduino library I'm working on. The port allows the usage of both liblo and libmapper on the Arduino ESP32 platform.
malloc(0) returns either a null pointer or a unique pointer according to the standard
https://pubs.opengroup.org/onlinepubs/009695399/functions/malloc.html
Therefore I think it makes sense to check whether remain > 0
The IP_MULTICAST_LOOP socket option is necessary for libmapper and it defaults to 1 on Linux/macOS. On the ESP32 it defaults to 0. Therefore setting it to 1 should not break any current applications.
The closesocket thing is because the TCP/IP library LWIP defines closesocket as an inline function and therefore it can't be redefined.