Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32 compatibility #88

Merged
merged 2 commits into from
Jan 29, 2020
Merged

ESP32 compatibility #88

merged 2 commits into from
Jan 29, 2020

Conversation

mathiasbredholt
Copy link
Contributor

I'm submitting this pull request to make liblo compatible with the libmapper Arduino library I'm working on. The port allows the usage of both liblo and libmapper on the Arduino ESP32 platform.

malloc(0) returns either a null pointer or a unique pointer according to the standard
https://pubs.opengroup.org/onlinepubs/009695399/functions/malloc.html
Therefore I think it makes sense to check whether remain > 0

The IP_MULTICAST_LOOP socket option is necessary for libmapper and it defaults to 1 on Linux/macOS. On the ESP32 it defaults to 0. Therefore setting it to 1 should not break any current applications.

The closesocket thing is because the TCP/IP library LWIP defines closesocket as an inline function and therefore it can't be redefined.

@mathiasbredholt mathiasbredholt mentioned this pull request Oct 19, 2019
@radarsat1
Copy link
Owner

Thanks Matthias, I will check this when I get a chance!

@radarsat1 radarsat1 merged commit 5f0b23c into radarsat1:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants