Fix #474: allow vagrant localhost ssh in vm_devbox #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robnagler you mentioned using unique passwords for vagrant instead of the default. Is that still something you think is necessary? I'll need to test that nothing breaks but I assume we can just set the password for the vagrant user when provisioning the vm. Also, should we change the root password? |
e-carlin
force-pushed
the
474-devbox-ssh
branch
2 times, most recently
from
dbbbabe
to
4bec2d0
Compare
Allow ssh connections from vagrant over localhost in vm_devbox. This allows services like sirepo.job_driver.sbatch to connect over localhost back in to the host via ssh to start a job_agent.
|
We should delete the password for the vagrant user and root. The user can then set the password when they need it. We should add a quick check on setup of Slurm that tells the user what to do (what env var to set, for example). |
robnagler
approved these changes
Apr 1, 2024
|
please review again with the addition of |
robnagler
requested changes
Apr 1, 2024
…into 474-devbox-ssh
robnagler
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow ssh connections from vagrant over localhost in vm_devbox. This allows services like sirepo.job_driver.sbatch to connect over localhost back in to the host via ssh to start a job_agent.