Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #4610: Add input arg descriptions to sirepo.api.Spec #4612

Merged
merged 10 commits into from
Jul 28, 2022
Merged

fix #4610: Add input arg descriptions to sirepo.api.Spec #4612

merged 10 commits into from
Jul 28, 2022

Conversation

rorour
Copy link
Contributor

@rorour rorour commented Jul 16, 2022

No description provided.

@rorour rorour requested a review from robnagler July 16, 2022 00:37
robnagler
robnagler requested changes Jul 19, 2022
View reviewed changes
Copy link
Member

@robnagler robnagler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All types should be constrainable. No unlimited types like String. PKDict is not a "type" so it should SimData or maybe a new type, depending on the context. I caught many but others may need fixing up.

sirepo/job_api.py Outdated Show resolved Hide resolved
sirepo/job_api.py Outdated Show resolved Hide resolved
sirepo/job_api.py Outdated Show resolved Hide resolved
sirepo/server.py Outdated Show resolved Hide resolved
sirepo/server.py Outdated Show resolved Hide resolved
sirepo/auth/email.py Outdated Show resolved Hide resolved
sirepo/auth_role_moderation.py Outdated Show resolved Hide resolved
sirepo/auth_role_moderation.py Outdated Show resolved Hide resolved
sirepo/comsol_register.py Outdated Show resolved Hide resolved
sirepo/job_api.py Outdated Show resolved Hide resolved
@rorour rorour requested a review from robnagler July 20, 2022 16:19
robnagler
robnagler requested changes Jul 20, 2022
View reviewed changes
Copy link
Member

@robnagler robnagler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to understand the difference between inputs and values that are computed from inputs.

sirepo/job_api.py Outdated Show resolved Hide resolved
sirepo/job_api.py Outdated Show resolved Hide resolved
sirepo/server.py Outdated Show resolved Hide resolved
sirepo/server.py Outdated Show resolved Hide resolved
sirepo/server.py Outdated Show resolved Hide resolved
sirepo/server.py Show resolved Hide resolved
sirepo/server.py Outdated Show resolved Hide resolved
sirepo/server.py Outdated Show resolved Hide resolved
sirepo/server.py Outdated Show resolved Hide resolved
sirepo/server.py Outdated Show resolved Hide resolved
@rorour rorour requested a review from robnagler July 20, 2022 22:27
@robnagler robnagler mentioned this pull request Jul 21, 2022
Closed
@rorour
Copy link
Contributor Author

rorour commented Jul 28, 2022

@robnagler have you gotten a chance to look at this?

robnagler
robnagler approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@robnagler robnagler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@robnagler robnagler merged commit ce3732d into master Jul 28, 2022
@robnagler robnagler deleted the 4610-api-spec-kwargs branch July 28, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-carlin e-carlin e-carlin left review comments

@robnagler robnagler robnagler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rorour @robnagler @e-carlin