Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update slurm adapter for ORNL andes cluster #823

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

wjlei1990
Copy link
Contributor

No description provided.

@mtitov
Copy link
Collaborator

mtitov commented Mar 5, 2021

hi @wjlei1990, can you please try to add 'andes' in self.rm.host.lower() to the line 577 instead of 583 (right after longhorn)?

@wjlei1990
Copy link
Contributor Author

For now, I don't set "--ntasks" or "-n" in my slurm header. I don't know if it is needed or not...

@mtitov
Copy link
Collaborator

mtitov commented Mar 5, 2021

RP will set a number of requested cores for this option (as an upper threshold). Don't have a strong opinion about this, since the following option --ntasks-per-node will be set (we don't have a resource config for Andes yet, but cores_per_node will be set there and that corresponding value will be used for --ntasks-per-node).

@mtitov mtitov requested a review from andre-merzky March 5, 2021 18:49
Copy link
Member

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtitov mtitov merged commit d0121d1 into radical-cybertools:devel Mar 8, 2021
@mtitov mtitov mentioned this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants