Remove orphaned tracks and channels on user delete #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the already existing
delete_user()function.It will now also
accountdelete_user()is calledIf you delete a channel, but not your user, tracks are still not removed, since they might be referenced by other channel_tracks. BUT, on the next
delete_user()call it'll be cleaned up.As an alternative to this approach, we could disable the multi-channel/track schema for now. Add user_id to channels and channel_id to tracks. Then we can clean it up easy with SQL cascades, and don't need this stuff.