feat(rrh)!: Upload completed recordings via SFTP #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paraenggu
force-pushed
the
feat/rrh-sftp-support
branch
from
953618d
to
5addebf
Compare
paraenggu
force-pushed
the
feat/rrh-sftp-support
branch
6 times, most recently
from
6f51dae
to
966a551
Compare
paraenggu
force-pushed
the
feat/rrh-sftp-support
branch
6 times, most recently
from
90a8499
to
fc23565
Compare
BREAKING CHANGE: Completed recordings will be uploaded via SFTP to an SSH/SFTP server instead of moving them to a destination directory.
paraenggu
force-pushed
the
feat/rrh-sftp-support
branch
from
fc23565
to
c2e7a5a
Compare
paraenggu
changed the title
codez
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
raar-record-handlerbehaviour. Completed recordings will be uploaded via SFTP to an SSH/SFTP server instead of moving them to a destination directory.This is a breaking change, as it won't support the previous file move anymore. In case anyone depends on the previous use case, multiple actions could be introduced to support both cases, but this is out of scope for now.
Update 2024-09-19:
The adapted script runs in production without issues since more than 7 months now.