Recording stabilizations #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent xruns (JackEngine::XRun) on low-end systems, the period size (--period, the number of frames between JACK process() calls) was raised from the default of 1024 to 2048. While this yields in higher latency, xruns should be less likely to happen.
To prevent ringbuffer overflows on busy or slow systems, the length of the ringbuffer was raised from the default of 2 to 10 seconds. This should prevent the following errors: Ringbuffer A overflowed while writing audio Ringbuffer B overflowed while writing audio.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR tries to address recently observed recording issues, by increasing buffers on jackd and rotter. While this leads to higher latency, the recording should be more stable on busy or low-end systems.