Check pods are created before waiting for them to be ready during publish recipes #6914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lish recipes Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
vinayada1
changed the title
vinayada1
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
rynowak
reviewed
Dec 4, 2023
vinayada1
force-pushed
the
publish-failure
branch
2 times, most recently
from
35bd9fb
to
cebfc27
Compare
Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
vinayada1
force-pushed
the
publish-failure
branch
from
cebfc27
to
94f93f8
Compare
vinayada1
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
ytimocin
approved these changes
Dec 4, 2023
rynowak
approved these changes
Dec 4, 2023
lakshmimsft
approved these changes
Dec 5, 2023
mauriciovasquezbernal
added a commit
to inspektor-gadget/inspektor-gadget
that referenced
this pull request
Feb 12, 2024
Tests on ARO were failing with: "error: no matching resources found", this because it's not possible to watch a resource that hasn't been created. See kubernetes/kubernetes#83094 & radius-project/radius#6914 Fixes: 4e1bb64 ("integration: Disable installing Security Profile Operator") Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
mauriciovasquezbernal
added a commit
to inspektor-gadget/inspektor-gadget
that referenced
this pull request
Feb 12, 2024
Tests on ARO were failing with: "error: no matching resources found", this because it's not possible to watch a resource that hasn't been created. See kubernetes/kubernetes#87352 & radius-project/radius#6914 Fixes: 4e1bb64 ("integration: Disable installing Security Profile Operator") Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
mauriciovasquezbernal
added a commit
to inspektor-gadget/inspektor-gadget
that referenced
this pull request
Feb 13, 2024
Tests eere failing on ARO because of different reasons: - In order to mount host path volumes, it's needed to use a different service account. - The "no matching resources found" error was because it's not possible to watch a resource that hasn't been created. See kubernetes/kubernetes#87352 This commit fixes the previous one by: - Defining a different service account to be able to mount hostpath volumes - Use kubectl rollout instead of kubectl wait as done in radius-project/radius#6914 This also updates the logic to remove the installed seccomp profile from the host. Fixes: 4e1bb64 ("integration: Disable installing Security Profile Operator") Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
mauriciovasquezbernal
added a commit
to inspektor-gadget/inspektor-gadget
that referenced
this pull request
Feb 13, 2024
Tests eere failing on ARO because of different reasons: - In order to mount host path volumes, it's needed to use a different service account. - The "no matching resources found" error was because it's not possible to watch a resource that hasn't been created. See kubernetes/kubernetes#87352 This commit fixes the previous one by: - Defining a different service account to be able to mount hostpath volumes - Use kubectl rollout instead of kubectl wait as done in radius-project/radius#6914 This also updates the logic to remove the installed seccomp profile from the host. Fixes: 4e1bb64 ("integration: Disable installing Security Profile Operator") Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
mauriciovasquezbernal
added a commit
to inspektor-gadget/inspektor-gadget
that referenced
this pull request
Feb 13, 2024
Tests are failing on ARO because of different reasons: - In order to mount host path volumes, it's needed to use a different service account. - The "no matching resources found" error was because it's not possible to watch a resource that hasn't been created. See kubernetes/kubernetes#87352 This commit fixes the previous one by: - Defining a different service account to be able to mount hostpath volumes - Use kubectl rollout instead of kubectl wait as done in radius-project/radius#6914 This also updates the logic to remove the installed seccomp profile from the host. Fixes: 4e1bb64 ("integration: Disable installing Security Profile Operator") Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a potential fix for the flaky test issue seen #6912
It is possible that we see error: no matching resources found because the pods are not yet created. Waiting on non-existent resources can result in this error (kubernetes/kubernetes#87352)
Adding a kubectl rollout status which will ensure the pods are created before waiting on them to become ready
Type of change
Fixes: #6912
Auto-generated summary
🤖[deprecated] Generated by Copilot at 27fbda2
Summary
🚀🧪🎨
Add feature to generate and test Terraform recipes from YAML. Fix formatting in
build/recipes.mk.Walkthrough