Use unique resource names in test Terraform Recipe #7108
Conversation
kachawla
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
| storage_account_name = azurerm_storage_account.test_storage_account.name | ||
| } | ||
|
|
||
| resource "azurerm_storage_blob" "test_blob" { | ||
| name = "test-blob" |
There was a problem hiding this comment.
Good catch. I think it might be related to this or test-container above. I don't think it is due to another long-running test deleting it but a functional test that happens to be running at the same time might be deleting one of these.
There was a problem hiding this comment.
I don't think it is due to another long-running test deleting it but a functional test that happens to be running at the same time might be deleting one of these.
Interesting. Are we sharing resource groups between functional tests and long running tests?
I think it might be related to this or test-container above.
The failure is due to test-container but I just decided to add uniqueness to all resource names.
There was a problem hiding this comment.
Interesting. Are we sharing resource groups between functional tests and long running tests?
No, we are not actually. They all belong to a resource group, right? Can't seem to find out why this is caused for now.
|
Just saw this error: |
No, just wanted to check that it runs successfully with the updated names, but looks like we need to make it compliant with naming restrictions, will look into it and update. |
kachawla
force-pushed
the
kachawla/tfrecipe-test
branch
from
0a5c1e0
to
508e442
Compare
kachawla
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Signed-off-by: karishma-chawla <74574173+karishma-chawla@users.noreply.github.com>
kachawla
force-pushed
the
kachawla/tfrecipe-test
branch
from
508e442
to
f818784
Compare
kachawla
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
kachawla
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Updated |
# Description Trying a fix for radius-project#7060. Resource name uniqueness is tied to resource group right now, potentially causing concurrency issues. ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: radius-project#7060 Signed-off-by: karishma-chawla <74574173+karishma-chawla@users.noreply.github.com> Co-authored-by: karishma-chawla <74574173+karishma-chawla@users.noreply.github.com>
Description
Trying a fix for #7060. Resource name uniqueness is tied to resource group right now, potentially causing concurrency issues.
Type of change
Attempting fix for #7060