Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Namespace.ValidateNamespace to add workspace to arguments #7154

Merged
merged 2 commits into from
Feb 10, 2024
Merged

Update Namespace.ValidateNamespace to add workspace to arguments #7154

merged 2 commits into from
Feb 10, 2024

Conversation

jhandel
Copy link
Contributor

@jhandel jhandel commented Feb 9, 2024

Signed-off-by: Josh josh@liveoak.ws

Description

in order for the non current context to be used by ValidateNamespaces so that it can create namespaces in the workspaces kubernetes context we need to pass in the workspace and then use workspace.KuberneteContext() to look up the correct context.

Type of change

This pull request fixes a bug in Radius and has an approved issue (issue link required).

Fixes: #5698

@jhandel jhandel requested review from a team as code owners February 9, 2024 17:59
@radius-functional-tests
Copy link

radius-functional-tests bot commented Feb 9, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository jhandel/radius
Commit ref 384d1e3
Unique ID 303d0ad8f7
Image tag pr-303d0ad8f7
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-303d0ad8f7
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-303d0ad8f7
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-303d0ad8f7
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-303d0ad8f7
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting kubernetes functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting shared functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ ucp functional tests succeeded
✅ shared functional tests succeeded

@ytimocin
Copy link
Contributor

ytimocin commented Feb 9, 2024

Thanks for your contribution @jhandel! You should run make generate. Please see: https://github.com/radius-project/radius/actions/runs/7847801524/job/21417564330?pr=7154.

@jhandel
Generating updated mock for namespace and updating create_test for th…
18f2f67 
…e new mock.

Signed-off-by: Josh <josh@liveoak.ws>
@jhandel
Copy link
Contributor Author

jhandel commented Feb 9, 2024

Thanks for your contribution @jhandel! You should run make generate. Please see: https://github.com/radius-project/radius/actions/runs/7847801524/job/21417564330?pr=7154.

sorry about that.. I thought I read somewhere that the generated code wasn't checked in so it could always be re-generated so I kind of ignored that assuming the build would run the generator..

Anyways, generated the updated code and checked..

@radius-functional-tests
Copy link

radius-functional-tests bot commented Feb 9, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository jhandel/radius
Commit ref 18f2f67
Unique ID 33856fcce1
Image tag pr-33856fcce1
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-33856fcce1
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-33856fcce1
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-33856fcce1
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-33856fcce1
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting kubernetes functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

@ytimocin ytimocin merged commit 647c0c7 into radius-project:main Feb 10, 2024
16 checks passed
@ytimocin
Copy link
Contributor

Thanks for your contribution @jhandel !

@jhandel jhandel deleted the fix_5698 branch February 10, 2024 01:18
willdavsmith pushed a commit to willdavsmith/radius that referenced this pull request Feb 23, 2024
@jhandel @willdavsmith
Update Namespace.ValidateNamespace to add workspace to arguments (rad…
2196169 
…ius-project#7154)

Signed-off-by: Josh <josh@liveoak.ws>

# Description

in order for the non current context to be used by ValidateNamespaces so
that it can create namespaces in the workspaces kubernetes context we
need to pass in the workspace and then use workspace.KuberneteContext()
to look up the correct context.

## Type of change

This pull request fixes a bug in Radius and has an approved issue (issue
link required).

Fixes: radius-project#5698

---------

Signed-off-by: Josh <josh@liveoak.ws>
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
willdavsmith pushed a commit to willdavsmith/radius that referenced this pull request Mar 4, 2024
@jhandel @willdavsmith
Update Namespace.ValidateNamespace to add workspace to arguments (rad…
0c4456f 
…ius-project#7154)

Signed-off-by: Josh <josh@liveoak.ws>

# Description

in order for the non current context to be used by ValidateNamespaces so
that it can create namespaces in the workspaces kubernetes context we
need to pass in the workspace and then use workspace.KuberneteContext()
to look up the correct context.

## Type of change

This pull request fixes a bug in Radius and has an approved issue (issue
link required).

Fixes: radius-project#5698

---------

Signed-off-by: Josh <josh@liveoak.ws>
willdavsmith pushed a commit to willdavsmith/radius that referenced this pull request Apr 8, 2024
@jhandel @willdavsmith
Update Namespace.ValidateNamespace to add workspace to arguments (rad…
0d08a98 
…ius-project#7154)

Signed-off-by: Josh <josh@liveoak.ws>

# Description

in order for the non current context to be used by ValidateNamespaces so
that it can create namespaces in the workspaces kubernetes context we
need to pass in the workspace and then use workspace.KuberneteContext()
to look up the correct context.

## Type of change

This pull request fixes a bug in Radius and has an approved issue (issue
link required).

Fixes: radius-project#5698

---------

Signed-off-by: Josh <josh@liveoak.ws>
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytimocin ytimocin ytimocin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environment validation in rad env create is wrong
2 participants
@jhandel @ytimocin