Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/scrypto-bindgen lib #1826

Merged
merged 3 commits into from
May 29, 2024
Merged

Conversation

talekhinezh
Copy link
Member

  • Move scrypto-bindgen logic from radix-clis crate to it's own scrypto-bindgen crate

@talekhinezh talekhinezh force-pushed the refactor/move-scrypto-bindgen branch from 463b877 to 194f4aa Compare May 28, 2024 20:55
Copy link

github-actions bot commented May 28, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:2a301fa57c

Copy link

github-actions bot commented May 28, 2024

Benchmark for 2a301fa

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 65.3±0.15ms 65.5±0.17ms +0.31%
costing::decode_sbor 10.7±0.02µs 10.7±0.02µs 0.00%
costing::decode_sbor_bytes 29.8±0.09µs 29.5±0.03µs -1.01%
costing::deserialize_wasm 1308.1±5.02µs 1311.9±24.84µs +0.29%
costing::instantiate_flash_loan 4.0±0.66ms 4.0±0.75ms 0.00%
costing::instantiate_radiswap 5.9±0.08ms 5.7±0.09ms -3.39%
costing::spin_loop 21.7±0.08ms 22.8±0.32ms +5.07%
costing::validate_sbor_payload 26.0±0.03µs 27.9±0.06µs +7.31%
costing::validate_sbor_payload_bytes 231.0±0.54ns 246.4±0.92ns +6.67%
costing::validate_secp256k1 76.4±0.29µs 76.3±0.11µs -0.13%
costing::validate_wasm 36.7±0.04ms 36.6±0.06ms -0.27%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.9±0.01ns 9.9±0.00ns 0.00%
decimal::add/wasmer 114.7±0.10ns 114.6±0.10ns -0.09%
decimal::add/wasmer-call-native 453.0±1.26ns 451.1±0.28ns -0.42%
decimal::add/wasmi 607.7±1.20ns 602.6±0.36ns -0.84%
decimal::add/wasmi-call-native 5.4±0.01µs 5.4±0.01µs 0.00%
decimal::div/0 191.1±0.41ns 190.8±0.19ns -0.16%
decimal::from_string/0 153.3±0.14ns 152.7±0.17ns -0.39%
decimal::mul/0 141.8±0.43ns 142.5±0.28ns +0.49%
decimal::mul/rust-native 137.0±0.23ns 136.8±0.56ns -0.15%
decimal::mul/wasmer 1501.6±3.97ns 1510.2±0.53ns +0.57%
decimal::mul/wasmer-call-native 584.0±1.05ns 580.3±0.72ns -0.63%
decimal::mul/wasmi 41.5±0.21µs 41.8±0.27µs +0.72%
decimal::mul/wasmi-call-native 5.6±0.03µs 5.6±0.01µs 0.00%
decimal::pow/0 652.7±0.50ns 650.4±0.64ns -0.35%
decimal::pow/rust-native 631.3±0.88ns 631.9±0.78ns +0.10%
decimal::pow/wasmer 6.6±0.00µs 6.6±0.00µs 0.00%
decimal::pow/wasmer-call-native 1036.2±1.23ns 1025.5±1.16ns -1.03%
decimal::pow/wasmi 195.4±0.26µs 198.1±0.48µs +1.38%
decimal::pow/wasmi-call-native 5.4±0.02µs 5.3±0.01µs -1.85%
decimal::root/0 8.0±0.02µs 7.8±0.01µs -2.50%
decimal::sub/0 8.5±0.01ns 8.5±0.01ns 0.00%
decimal::to_string/0 435.8±0.26ns 435.9±0.32ns +0.02%
precise_decimal::add/0 9.2±0.14ns 9.4±0.06ns +2.17%
precise_decimal::add/rust-native 11.4±0.00ns 11.4±0.00ns 0.00%
precise_decimal::add/wasmer 122.8±0.11ns 122.6±0.19ns -0.16%
precise_decimal::add/wasmer-call-native 495.0±0.71ns 487.0±0.68ns -1.62%
precise_decimal::add/wasmi 775.9±1.18ns 772.9±0.97ns -0.39%
precise_decimal::add/wasmi-call-native 6.9±0.01µs 7.1±0.01µs +2.90%
precise_decimal::div/0 303.3±0.30ns 302.5±2.23ns -0.26%
precise_decimal::from_string/0 200.4±0.48ns 200.7±0.23ns +0.15%
precise_decimal::mul/0 345.6±1.24ns 343.0±0.47ns -0.75%
precise_decimal::mul/rust-native 304.2±3.39ns 307.0±1.81ns +0.92%
precise_decimal::mul/wasmer 3.5±0.00µs 3.5±0.00µs 0.00%
precise_decimal::mul/wasmer-call-native 808.1±2.61ns 807.2±1.45ns -0.11%
precise_decimal::mul/wasmi 106.5±0.27µs 107.0±0.29µs +0.47%
precise_decimal::mul/wasmi-call-native 7.4±0.01µs 7.4±0.02µs 0.00%
precise_decimal::pow/0 1846.1±2.51ns 1862.6±2.99ns +0.89%
precise_decimal::pow/rust-native 1472.8±3.52ns 1470.6±1.64ns -0.15%
precise_decimal::pow/wasmer 16.2±0.02µs 16.3±0.01µs +0.62%
precise_decimal::pow/wasmer-call-native 2.1±0.00µs 2.1±0.00µs 0.00%
precise_decimal::pow/wasmi 516.0±0.83µs 518.0±0.64µs +0.39%
precise_decimal::pow/wasmi-call-native 13.0±0.05µs 13.1±0.06µs +0.77%
precise_decimal::root/0 56.3±0.04µs 56.6±0.03µs +0.53%
precise_decimal::sub/0 9.6±0.09ns 9.4±0.01ns -2.08%
precise_decimal::to_string/0 722.5±1.58ns 720.4±3.73ns -0.29%
schema::validate_payload 361.2±0.42µs 341.7±0.31µs -5.40%
transaction::radiswap 5.3±0.02ms 5.3±0.03ms 0.00%
transaction::transfer 1737.1±8.21µs 1749.9±7.22µs +0.74%
transaction_processing::prepare 2.2±0.00ms 2.2±0.00ms 0.00%
transaction_processing::prepare_and_decompile 6.1±0.05ms 6.0±0.01ms -1.64%
transaction_processing::prepare_and_decompile_and_recompile 25.8±1.68ms 24.1±0.92ms -6.59%
transaction_validation::validate_manifest 42.1±0.03µs 42.3±0.52µs +0.48%
transaction_validation::verify_bls_2KB 1046.3±73.75µs 1031.7±64.24µs -1.40%
transaction_validation::verify_bls_32B 1051.4±82.71µs 1065.3±114.76µs +1.32%
transaction_validation::verify_ecdsa 74.6±0.07µs 74.3±0.05µs -0.40%
transaction_validation::verify_ed25519 55.1±0.05µs 55.1±0.15µs 0.00%

Copy link
Member

@iamyulong iamyulong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to add the new crate to our publish workflow either here or on #1805, depending on which gets merged first.

scrypto-bindgen/Cargo.toml Show resolved Hide resolved
Copy link
Member

@0xOmarA 0xOmarA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, no changes required from my side.

@iamyulong iamyulong merged commit c029731 into develop May 29, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants