-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect scrypto compilation with lock file #1832
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker tags |
Benchmark for 5e4ae16Click to view benchmark
|
lrubasze
force-pushed
the
tweaks/scrypto_compiler_improvements
branch
2 times, most recently
from
June 10, 2024 17:10
d71d2a5
to
8e2a10e
Compare
lrubasze
force-pushed
the
tweaks/scrypto_compiler_improvements
branch
from
June 12, 2024 07:40
57d3ed4
to
cc5b25a
Compare
iamyulong
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change introduces a protection of Scrypto build artifacts with lock file.
This is important when multiple Scrypto compilation processes are invoked in parallel.
Compilation time for multiple compilations increases slightly.
Additionally:
Run Radix Engine tests
but apparently it was rebuilding RE massively instead of reusing build artifacts from thecargo nextest run
. Discovered that we need to provide exactly the same list of packages in order to benefit from incremental build.Testing
Parallel compilation test added.